-
Notifications
You must be signed in to change notification settings - Fork 161
Fix: Update service catalog documentation link to latest version #1222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Updated docUrl from version 4.6.0 to latest in settings.json - Changed documentation path to include 'manage-apis' prefix - Fixed line length linting issue by splitting long URL string - Documentation now points to: https://apim.docs.wso2.com/en/latest/manage-apis/design/create-api/create-an-api-using-a-service/
WalkthroughTwo documentation URLs are updated: the global docUrl configuration is changed to reference the latest version instead of 4.6.0, and the Service Catalog "Get Started" link is redirected to the correct API design documentation path. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| "loadDefaultLocales": false, | ||
| "supportedDocTypes": "application/vnd.openxmlformats-officedocument.wordprocessingml.document, application/msword, application/pdf, text/plain, application/vnd.ms-excel, application/vnd.openxmlformats-officedocument.spreadsheetml.sheet, application/vnd.oasis.opendocument.text, application/vnd.oasis.opendocument.spreadsheet, application/json, application/x-yaml, .yaml, .md", | ||
| "docUrl": "https://apim.docs.wso2.com/en/4.6.0/", | ||
| "docUrl": "https://apim.docs.wso2.com/en/latest/", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ranuka-laksika This needs to be kept version-specific (4.6.0), as each release is required to point to its respective documentation space.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed to 4.6.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HeshanSudarshana we are doing this fix in the main branch. So, if we keep a specific version (say 4.6.0), what happens when we do a new release? That release will go with 4.6.0 doc link. Isn't that wrong? Isn't there a better fix for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amilam usually at the start of a release cycle, we change the product version which are set to the previous release version to the next release version [1][2].
Therefore, changing only this URL could introduce a bit of a maintenance overhead to keep track of in future releases.
[1] https://github.com/wso2/apim-apps/pull/1045/files
[2] https://github.com/wso2/apim-apps/pull/1054/files
The comment needs to be addressed before merging
|



Fixes wso2/api-manager#4538
Issue URL: wso2/api-manager#4538
Problem
The documentation link in the service catalog main page of the APIM Publisher portal was pointing to an outdated URL path and version-specific documentation.
Solution
Updated the documentation URL to point to the latest version and corrected the path structure:
design/create-api/create-an-api-using-a-service/tomanage-apis/design/create-api/create-an-api-using-a-service/Changes Made
portals/publisher/src/main/webapp/site/public/conf/settings.jsondocUrlfromhttps://apim.docs.wso2.com/en/4.6.0/tohttps://apim.docs.wso2.com/en/latest/portals/publisher/src/main/webapp/source/src/app/components/ServiceCatalog/Listing/Onboarding.jsxmanage-apisprefixBuild Information
publisher.war(32MB)Artifacts Replaced
publisherfolder inwso2am-4.6.0/repository/deployment/server/webapps/Testing
No testing required for frontend changes (as per workflow guidelines for apim-apps repository).
Modified wso2am Pack Download
The complete modified
wso2am-4.6.0pack is available as a GitHub Actions artifact.🔗 Download from GitHub Actions
Artifact Details:
wso2am-4.6.0-issue-56.zipContents: Complete wso2am pack with all updated artifacts ready to use.
Summary by CodeRabbit